Repository navigation
Show bond hover previews in the browser editor - #543
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I found that selecting Bond and moving the pointer over the browser canvas produced no faint preview until a mouse press. The unpressed pointer path refreshed only the Ring and Mark previews.
Changes
Verification
bash scripts/check.sh— passed on macOS with Python 3.13.14: 16,914 passed, 424 skipped and 1,036 passing subtests; Ruff, formatting and mypy passed. Full line coverage 94.40%, branch coverage 86.52%. RDKit was not installed.node --test --experimental-test-coverage tests/web_adapter.test.mjs— 187 passed. Against the merged baseline, the four new regressions fail while the existing 183 tests pass.Related issue
User-reported missing Bond hover preview in the browser editor.
Checklist
CHANGELOG.mdunderUnreleased.Notes for reviewers
The preview uses the shared committed-drawing planner. Exact native geometry parity for labelled atoms, ring/neighbour context and perspective is not established by the two-carbon fixture. After a cancelled press, the preview resumes on the next pointer movement. Preview requests replan on a copy with one request in flight.