Repository navigation
Stabilize CDXML export and prepare Qt-only 0.24.0 - #544
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I found that ordinary benzene and multiple bonds could be refused by CDXML export because their stored styles did not match the drawn bonds. The main branch's build configuration also included the experimental browser editor, which is being retained for future Leaf integration.
Changes
--ui webusers a clear explanation.Verification
make checkon macOS arm64 / Python 3.13.14 without RDKit: 16,977 passed, 428 skipped, 1,036 subtests passed; line coverage 94.39%, branch coverage 86.52%. Includes the four serial Cocoa workflow files. An initial documentation code-fence mismatch was corrected before the full passing rerun.python -m build --no-isolation,python scripts/verify_dist.py dist/*, andpython -m twine check dist/*: passed for 0.24.0; the wheel was built from the sdist. A clean environment passed version/help/Qt-help and web-refusal checks, plus the exact CI wheel smoke.Interactive Qt/ChemDraw checks were unavailable in this environment. CDXML import, complete document roundtrips, and ChemDraw visual equivalence are not claimed. Frozen-app spec tests do not replace building and launching a native bundle.