Repository navigation
Conversation
User guides and packaging notes still described SMILES insertion, Molecule Info, reaction mapping, the rdkit extra, and machine.json output after those features were removed. Record that boundary in ADR 0035 and keep 0.25.0.dev0 unpublished. Co-authored-by: daehyupsohn <dhsohn@users.noreply.github.com>
The tutorial now draws ring, carbon, then the terminal atom, and doubles only the product's second bond. Contributor docs follow the Linux test job and the per-file runner. Co-authored-by: daehyupsohn <dhsohn@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Commit
932c0607e16e9192f69625bc430a3a628a3961afremoved SMILES insertion, Molecule Info, the 3D preview, XYZ export, reaction mapping, therdkitextra, andmachine.jsonoutput. The user guides, packaging notes, and the observation-provider claim still described those features.Changes
machine.jsonand does not record a replacement provider, a core version, or an execution approval for any other project.__version__stays0.25.0.dev0. Release preparation is described separately from tagging and publishing. The Windows bundle spec still requires a numericmajor.minor.patchbefore a bundle or tag.tests/test_docs_sync.pyrejects the removed install strings and commands in the current guides.dff496f(review fixes for two documentation defects):tests/test_first_scheme_guide.pyreplays the guide's tool order and checks 8 atoms and 8 bonds.testjob, coverage, andrun_test_files.sh. The docs check fails if a deleted check path reappears.Verification
Identity before the edit: task
bc-72e73971-e173-51a5-8db2-557df848b1b8, origingithub.com/dhsohn/Chemvas, checkout932c0607e16e9192f69625bc430a3a628a3961af, parent04ed9e26fbb848268026cc1ea21987032d8616ef.Current head:
dff496f32a026e137aa79351cb1f94684d37919a(previous commitb24717f43212023ae55494f9bc67f44e71d6ce38; its 20-test run is superseded and is not evidence for this head).Linux, Qt offscreen, RDKit not installed. Selected files only, not a full-suite baseline.
tests/test_first_scheme_guide.py+tests/test_docs_sync.py: 22 passedCI on
dff496f(Actions run 37322231134): completed, conclusion success (2026-10-05 14:20 UTC).The macOS full-suite and Cocoa results recorded on
932c0607belong to that commit. They are not evidence for this documentation change. The rewritten quickstart was not recorded on a live canvas.Review scope
The two documentation defects were reviewed as resolved on
dff496fand approved for that scope only. This is not native QA of the full tutorial and not release completion.Related issue
None.
Checklist
make checkpasses — the whole local gate: lint, formatting, mypy, and the file-isolated test suitetests/test_architecture_boundaries.pystill passes)CHANGELOG.md(underUnreleased) if user-visibleNotes for reviewers
Remaining conditions:
make checkhas not been run on this commit.main, no tag, no PyPI publish, and no Windows installer build.0.25.0.dev0cannot build the Windows bundle until the version is a numeric triple.walkthrough-chemistry.gifis labeled historical and is not current UI evidence.Slack Thread