[WIP] Add FNV1a hash function#1760
Open
betatim wants to merge 2 commits into
Open
Conversation
Member
Author
|
Surprising how few tests fail with this! |
Member
|
nice :). |
Member
Author
|
Results from running this script as a benchmark. The thing to look at are the last three columns which measure how long how it takes to load kmers, lookup a kmer that isn't present and kmers which are present. Observations: the benchmark isn't very useful because it is pretty noisy and I'd conclude that FNV1a is no faster than murmurhash. I find that at least somewhat surprising. |
Member
|
Question for all y'all - are we benchmarking with different *numbers* of hash
tables? I'm wondering if the prime number modulus is causing any issues.
I am still stuck on the question of (a) whether things could be faster,
(b) if so, how easy it would be to speed things up. Right now we seem
to be stuck in the never never land of "it's hard to identify any one
factor that is slowing things down."
|
Codecov Report
@@ Coverage Diff @@
## master #1760 +/- ##
=========================================
+ Coverage 0.05% 0.06% +<.01%
=========================================
Files 87 78 -9
Lines 11441 9807 -1634
Branches 3072 2459 -613
=========================================
Hits 6 6
+ Misses 11435 9801 -1634
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1757
Test driving the FNV hash. Benchmarks to do:
make testDid it pass the tests?make clean diff-coverIf it introduces new functionality inscripts/is it tested?make format diff_pylint_report cppcheck doc pydocstyleIs it wellformatted?
additions are allowed without a major version increment. Changing file
formats also requires a major version number increment.
documented in
CHANGELOG.md? See keepachangelogfor more details.
changes were made?
tested for streaming IO?)