[WIP] Enable banding for computing k-mer abundance distributions#1767
Open
standage wants to merge 4 commits into
Open
[WIP] Enable banding for computing k-mer abundance distributions#1767standage wants to merge 4 commits into
standage wants to merge 4 commits into
Conversation
Member
Author
|
This depends on |
Member
Author
|
Some initial benchmarking this weekend: ran |
Member
Author
|
Hmm. The cyclic hash is not only faster than the murmur hash (we already knew that), but its speed benefits seem to stack better with threading. The commands I used: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Banding stuff has been pretty well battle tested in kevlar, but hasn't made it to the khmer CLI yet. This requires not only adding arguments to support banding, but integrating *table objects into the tooling originally designed only for *graph objects.
make testDid it pass the tests?make clean diff-coverIf it introduces new functionality inscripts/is it tested?make format diff_pylint_report cppcheck doc pydocstyleIs it wellformatted?
additions are allowed without a major version increment. Changing file
formats also requires a major version number increment.
documented in
CHANGELOG.md? See keepachangelogfor more details.
changes were made?
tested for streaming IO?)