Skip to content

[MRG] test, and actually fix, find-nullomers script; add documentation and test input file#1768

Open
ctb wants to merge 4 commits into
masterfrom
example/nullomers
Open

[MRG] test, and actually fix, find-nullomers script; add documentation and test input file#1768
ctb wants to merge 4 commits into
masterfrom
example/nullomers

Conversation

@ctb

@ctb ctb commented Sep 1, 2017

Copy link
Copy Markdown
Member

Fixes #1754.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make clean diff-cover If it introduces new functionality in
    scripts/ is it tested?
  • make format diff_pylint_report cppcheck doc pydocstyle Is it well
    formatted?
  • Did it change the command-line interface? Only backwards-compatible
    additions are allowed without a major version increment. Changing file
    formats also requires a major version number increment.
  • For substantial changes or changes to the command-line interface, is it
    documented in CHANGELOG.md? See keepachangelog
    for more details.
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Do the changes respect streaming IO? (Are they
    tested for streaming IO?)

@ctb

ctb commented Sep 1, 2017

Copy link
Copy Markdown
Member Author

Ready for review & merge.

@ctb

ctb commented Sep 1, 2017

Copy link
Copy Markdown
Member Author

I super strongly suspect I can get away with a smaller SIZE - SIZE/2, to be specific. Hmm.

@codecov-io

codecov-io commented Sep 1, 2017

Copy link
Copy Markdown

Codecov Report

Merging #1768 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1768   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files          80      80           
  Lines        9835    9835           
  Branches     2485    2485           
======================================
  Hits            5       5           
  Misses       9830    9830

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb29c77...99ae031. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants