Skip to content

switch to using c++ compiler instead of g++ to fix cpp-demos on mac os x#1865

Open
ctb wants to merge 44 commits into
masterfrom
mqf/ctbfix
Open

switch to using c++ compiler instead of g++ to fix cpp-demos on mac os x#1865
ctb wants to merge 44 commits into
masterfrom
mqf/ctbfix

Conversation

@ctb

@ctb ctb commented May 19, 2018

Copy link
Copy Markdown
Member

Try fixing compile errors for cpp-demos on Mac OS X, ref #1859 (comment), by switching to using the system C++ rather than g++.

This will be a pull request into #1859 after Travis finishes checking it.

I've also updated from the latest master branch, so this will update MQFintegration to be mergable.

@ctb

ctb commented May 19, 2018

Copy link
Copy Markdown
Member Author

Hmm, switching to pull into master so that we get continuous integration goin'.

@ctb ctb changed the base branch from MQFIntegration to master May 19, 2018 14:00
@ctb ctb mentioned this pull request May 19, 2018
8 tasks
@ctb ctb closed this May 19, 2018
@ctb ctb reopened this May 19, 2018
@ctb

ctb commented May 19, 2018

Copy link
Copy Markdown
Member Author

(closing and reopening seems to be the easiest way to trigger a new build)

@ctb

ctb commented May 21, 2018

Copy link
Copy Markdown
Member Author

hi again @shokrof, suggest opening yet another new pull request for you to experiment, rather than using this one. I'd like to avoid confusing each other with weird test changes :). See also #1859 (comment)

@shokrof

shokrof commented May 21, 2018

Copy link
Copy Markdown
Collaborator

I am thinking of developing a bot to brute force all the options for the compiler. It may have better intuition than me.

@drtamermansour drtamermansour mentioned this pull request Jun 19, 2018
5 tasks
@shokrof

shokrof commented Jun 19, 2018

Copy link
Copy Markdown
Collaborator

Bug is fixed in this pull request.
#1873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants