Fix: UX Refactor - 3 (#42) and SearchBox Optimization(#53)#54
Fix: UX Refactor - 3 (#42) and SearchBox Optimization(#53)#54pawansoni007 wants to merge 1 commit into
Conversation
UX Refactor (dicedb#42): - Add placeholder in search box - Add bottom padding equal to top navbar for balanced UI spacing - Show all command entries when the search box is in empty/initial state. SearchBox Optimization (IMPORTANT): - Fix: SearchBox re-rendering every second due to usePlayground custom hook's timer - Memoize SearchBox to prevent unnecessary updates - Decouple from custom hook's timer updates
|
@pawansoni007 please attach screenshots for the changes, and fix the build. |
|
I'll do the needful for the prettier and push the updated commit. Thanks Btw..what screenshots are you seeking for? |
@pawansoni007 , screenshots of the changes you made help us review PRs faster, otherwise it's hard to understand what changed without. testing locally. |
KaviiSuri
left a comment
KaviiSuri
left a comment
There was a problem hiding this comment.
Thank you so much for contributing!
I also had a few suggestions on the UI changes: https://www.loom.com/share/8c34be797b4740ea85a9f8da27e3e603?sid=97c0970e-df58-4999-a110-8e6ec40f1cd7
| const { decreaseCommandsLeft, timeLeft, commandsLeft } = | ||
| usePlayground(); | ||
|
|
||
| const MemoizedSearchBox = useMemo(() => <SearchBox />, []); |
There was a problem hiding this comment.
This seems like a hack we had to do because we don't have separate components for the 2 sections of playground (The Terminal and the Searchbox).
Can we just create a component for the Left Column of Playground (Terminal + Commands Left etc), and call usePlayground from it? Basically, neither the Searchbox or any of it's parents should care about the time or commandsLeft, these should be state of the sibling for Searchbox.
|
@pawansoni007 could you please address the conflicts? |
Brother, is it okay if i do this on Friday evening, I'm mysrlf feeling bad 'bout keeping it this long, something came up and I got completely engaged into that. |
3 participants
UX Refactor (#42):
SearchBox Optimization (IMPORTANT): #53