Skip to content

Dragonfly: Python35 porting#5

Closed
drmfinlay wants to merge 2 commits intodictation-toolbox:upstream-changesfrom
sathishkottravel:master
Closed

Dragonfly: Python35 porting#5
drmfinlay wants to merge 2 commits intodictation-toolbox:upstream-changesfrom
sathishkottravel:master

Conversation

@drmfinlay
Copy link
Member

Merge d4ngo/dragonfly PR 56 into this fork.

1) 2to3 has been used initially
2) string.letter -> string.ascii_letters
3) c_char(char)  -> c_char(ord(char)) , similar c_wchar
4) __str__(self) modified in action_base.py and state.py  ( #http://stackoverflow.com/questions/6812031/how-to-make-unicode-string-with-python3)
@drmfinlay
Copy link
Member Author

Just want to note here that I would like this to work for Python 2.7 as well as 3.5. I've noticed the following happens with Python 2.7 because of the incompatible syntax for print:

  File "ez_setup.py", line 68
    ), file=sys.stderr)
           ^
SyntaxError: invalid syntax

I think it would be better (and less of a headache) to continue developing dragonfly with Python 2.7 in mind and use 2to3 during install and testing, rather than maintaining separate branches or trying to unify the code-base for 2.7 and 3+. I'll add something on that soon.

@drmfinlay drmfinlay closed this Apr 2, 2018
@drmfinlay drmfinlay mentioned this pull request Apr 18, 2018
@LexiconCode LexiconCode added the Enhancement Enhancement existing feature label Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Enhancement existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants