Remove the Region cosmetic role toggle - #68
Open
diese-tech wants to merge 1 commit into
Open
Conversation
"Region" was a flat on/off button on the My Roles panel that granted or revoked a plain "GodForge • Region" Discord role with no way to pick an actual region — nothing else in the bot ever read it (it's unrelated to a queue's own region field, which is a real value set via Queue Settings). Confirmed via a live server screenshot: clicking it just toggles a role with no attached value, which reads as broken rather than as designed. Fixing it into a real region picker (a mutually-exclusive dropdown feeding into matching) is a small feature in its own right; removing the half-built toggle is the right scope for now. Removed "region" from the optional managed-role definitions, the managed-role settings keys, the My Roles button list, and the /party setup region_role flag. A "GodForge • Region" role already created on a live server before this change won't be auto-deleted — /party reset only touches roles still in the managed-role definitions — so it may need manual cleanup if it exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
My Roles'Regionbutton was a flat on/off toggle that granted or revoked a plainGodForge • RegionDiscord role — with no way to actually pick a region. Confirmed via a live server screenshot: clicking it just toggles a role with no attached value, and nothing else in the bot ever reads it (this is unrelated to a queue's ownregionfield, which is a real value set through Queue Settings and does feed matching/display).Turning it into a real region picker (a mutually-exclusive dropdown feeding into something the bot actually reads) would be a small feature in its own right. Removing the half-built toggle is the right scope here — it was reading as broken, not as designed.
What changed
regionfromOPTIONAL_ROLE_DEFINITIONSinutils/managed_roles.py.regionfromMANAGED_ROLE_KEYSinutils/settings.py.Regionbutton fromROLE_PREFERENCESinutils/setup_views.py(My Roles panel is now Solo/Jungle/Mid/Support/ADC/Captain/Substitute/LFG — 8 buttons instead of 9).region_roleflag from/party setup(utils/party_setup_command.py).Player-facing UX changes
My Rolesno longer shows aRegionbutton./party setup'sregion_roleoption is gone; existing invocations that pass it will get Discord's normal "unknown option" rejection like any removed slash-command parameter.Known limitation
A
GodForge • Regionrole already created on a live server before this change won't be auto-deleted./party resetonly iterates roles still present inROLE_DEFINITIONS, so a pre-existing Region role becomes untracked rather than cleaned up — an admin would need to delete it manually from the server's role list if it exists. This wasn't worth adding one-off legacy-cleanup code for, given the toggle only exists in one live guild so far.Tests
test_party_setup_registration.py,test_setup_views.py).Manual Discord test checklist
/party setup(fresh or re-run) — confirm the slash command no longer offers aregion_roleoption.My Roles— confirm there are 8 buttons and noRegionbutton.GodForge • Regionrole already exists on the test server from before this change, confirm it's left alone (not deleted) by/party setupor/party reset— delete it manually if you want it gone.🤖 Generated with Claude Code
Generated by Claude Code