Skip to content

fix(contract): let the reviewed item catalog resync #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diese-tech merged 1 commit into from
Sep 1, 2026
+11 −5
Merged

fix(contract): let the reviewed item catalog resync #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions supabase/tests/005_item_catalog.test.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,21 @@ SELECT ok(
'items reject malformed identifiers, names, URLs, and metadata'
);

-- The catalog grows and its provenance is restamped as diese-tech/smite-content-sync
-- discovers items, so an exact row count and a frozen source_updated_at both
-- fail on every reviewed sync. (The count here had already drifted from the
-- description, which still said 260.) What matters is that the seed is whole,
-- active, source-attributed, and carries provenance for every row; CI's
-- verify-seed-growth step is what stops the catalog shrinking.
SELECT ok(
(
SELECT count(*) = 265
AND count(*) FILTER (WHERE active) = 265
AND count(*) FILTER (WHERE source_url ~ '^https://www[.]smitefire[.]com/smite/item/') = 265
AND count(*) FILTER (WHERE source_updated_at = '2026-07-29T15:19:05.553Z'::timestamptz) = 265
SELECT count(*) >= 265
AND count(*) FILTER (WHERE active) = count(*)
AND count(*) FILTER (WHERE source_url ~ '^https://www[.]smitefire[.]com/smite/item/') = count(*)
AND count(*) FILTER (WHERE source_updated_at IS NOT NULL) = count(*)
FROM public.items
),
'the deterministic seed contains the 260-item active catalog'
'the deterministic seed contains the whole active, source-attributed item catalog'
);

SELECT * FROM finish();
Expand Down