chore: sync Smite 2 content - #83
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
diese-tech
force-pushed
the
automation/smite-content-sync
branch
10 times, most recently
from
August 12, 2026 14:33
4972c77 to
bab96d4
Compare
diese-tech
force-pushed
the
automation/smite-content-sync
branch
4 times, most recently
from
August 16, 2026 13:45
254501b to
6526024
Compare
diese-tech
force-pushed
the
automation/smite-content-sync
branch
from
August 17, 2026 13:53
6526024 to
adfc175
Compare
diese-tech
added a commit
that referenced
this pull request
Sep 1, 2026
Second hard-coded blocker in the same pipeline as #112. 005_item_catalog test 5 asserted an exact 265 rows and a frozen source_updated_at = '2026-07-29T15:19:05.553Z' across every row. A reviewed sync restamps that provenance by design, so the assertion failed on every content PR -- #83 carries 265 items, an unchanged catalog size, with provenance at 2026-08-07 and 2026-08-17, and failed purely on the timestamp. The failure was invisible until now: database-contract is gated on repository-state, which had been failing first on the hard-coded god count, so this suite had never run against a synced catalog. The assertion now requires the catalog to be whole, active, source-attributed, and carrying provenance on every row, with a floor rather than an exact count. The verify-seed-growth step added in #112 is what stops the catalog shrinking, and it already covers the items seed. The description had also drifted, claiming 260 while asserting 265. Verified on PostgreSQL against #83's shape: 265 rows with two distinct provenance timestamps pass where the frozen assertion fails, growth to 266 passes, and a null source_updated_at or an inactive row still fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smite 2 Content Sync Report
Generated: 2026-08-17T13:52:49.417Z
Summary
Gods
Added
Items
Missing from source
Preserved in canonical data; not discovered on this run. Review before assuming removal.
Review Notes
data/smite2/god-pools.json) are preserved from canonical data unless manually updated.data/smite2/item-build-pools.json), including chaos-build eligibility, are preserved from canonical data unless manually updated. Discovery never grants build eligibility on its own.Validation Warnings
Outcome
REVIEW_REQUIREDCanonical data was written, but human review is required before this is safe to publish downstream.
GodForge chaos eligibility