Skip to content

Add audited admin ticket actions and scouter corrections - #251

Draft
diese-tech wants to merge 2 commits into
mainfrom
agent/admin-ticket-scouter-corrections
Draft

Add audited admin ticket actions and scouter corrections#251
diese-tech wants to merge 2 commits into
mainfrom
agent/admin-ticket-scouter-corrections

Conversation

@diese-tech

Copy link
Copy Markdown
Owner

Summary

  • Make pending operation and stat-review tickets actionable through existing audited database RPCs.
  • Add a full-game scouter OCR correction editor using the canonical db-v1.13 contract.
  • Require signed original evidence, explicit player mappings, expected revision, idempotency key, correction reason, and final confirmation.
  • Retire the unsafe participant-only correction endpoint with an authenticated 410 response.

Why

Admins currently lose the ability to act when the original Discord review message is unavailable, while older pre-confirmation OCR submissions can persist incorrect names or stats. This adds a durable site recovery path without ad-hoc SQL or granting captains admin access.

Safety and impact

  • Writes require a Discord-backed admin identity; password-fallback sessions remain read-only.
  • Corrections replace the complete ten-player game atomically and fail closed on unsupported actions.
  • This PR does not perform any production correction or database migration.
  • Official player ownership and game-time season/team attribution remain unchanged.
  • Addresses SITE-04: atomic ticket actions in the admin queue #193 without broadening the generic ticket workflow.

Validation

  • 617 tests passed; 26 skipped.
  • Focused correction tests: 12 passed.
  • Focused ticket-action tests: 74 passed.
  • Typecheck passed.
  • Lint passed with 14 pre-existing warnings and no errors.
  • BEM check and production build passed.
  • Generated contract hash matches sal-database db-v1.13: 594c8c377eb871ccdb59f166a06dfe1d48e700a3bcff709fd8ad2374f83537b0.
  • git diff --check passed.

@vercel

vercel Bot commented Aug 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sal-draft-league Ready Ready Preview Aug 8, 2026 1:52pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants