You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
exposes host_review in the existing admin queue while preserving admin-only final approval
fails closed for cancelled/terminal reports and inactive or deletion-scheduled roster identities
Why
/report-result currently records a score but does not give the host a secure path to correct OCR-derived player stats before admin approval. This flow makes the web review the single screenshot entry point and keeps official publication behind the database/admin boundary.
This branch intentionally remains locked to released db-v1.17.0; after the database release, add a small generated-types/contract-lock pin commit before integration or deployment.
Configure a dedicated MATCH_REPORT_HOST_SESSION_SECRET of at least 32 characters.
Screenshot requests are sent one at a time and capped at 4 MB to remain below the Vercel Function request-body limit.
No production deployment or database write was performed.
Verification
121 test files passed, 1 skipped
772 tests passed, 26 skipped
npx tsc --noEmit
npx eslint . --quiet
npm run check:bem
npm run check:db-contract (released db-v1.17.0)
npm run build
git diff --check origin/main...HEAD
Full Discord → deployed site → protected database staging verification remains gated on db-v1.18.0 and deployment secrets.
#265 carries this branch unchanged and adds the contract pin this PR's rollout notes asked for: "This branch intentionally remains locked to released db-v1.17.0; after the database release, add a small generated-types/contract-lock pin commit before integration or deployment."
That release has shipped and been superseded — production is on db-v1.20.0 — so #265 advances the lock to the current release and re-vendors the generated types via npm run sync:db-contract. The types change is purely additive (702 insertions, zero deletions), and the route handlers in this branch now typecheck against the real RPC signatures instead of the v1.17.0 types that predated them.
Two Codex findings against that branch were also fixed there: the admin review path was discarding host-validated playerId values, and cancelled reports could be revived through the admin upload route. Both have regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
host_reviewin the existing admin queue while preserving admin-only final approvalWhy
/report-resultcurrently records a score but does not give the host a secure path to correct OCR-derived player stats before admin approval. This flow makes the web review the single screenshot entry point and keeps official publication behind the database/admin boundary.Part of #252.
Dependencies and rollout
db-v1.18.0.db-v1.17.0; after the database release, add a small generated-types/contract-lock pin commit before integration or deployment.MATCH_REPORT_HOST_SESSION_SECRETof at least 32 characters.No production deployment or database write was performed.
Verification
npx tsc --noEmitnpx eslint . --quietnpm run check:bemnpm run check:db-contract(releaseddb-v1.17.0)npm run buildgit diff --check origin/main...HEADFull Discord → deployed site → protected database staging verification remains gated on
db-v1.18.0and deployment secrets.