You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all thanks a lot for developing this crate, I've been able to move some more of our data analysis pipeline to Rust thanks to it.
While I can understand why you want to get rid of the num-traits dependency in your context (at least, from what I got from the commit message of f19d626), it's actually super practical to have it available because you can depend on custom float types, the most interesting one for me being f16 from the half crate to work with a reduced memory footprint. The drop of num-traits support prevented me from updating to v0.3.
This PR keeps the best of both worlds by hiding the num-traits dependency behind a feature gate, which is disabled by default. Users like me who want to use the Float trait from num-traits can enable the feature, but by default kodama remains without dependency.
I don't think I could, because f16 is also an external type, so I couldn't implement the Float trait from kodama. And given that f16 already implements Float from num-traits, that would actually require double the effort for something that is there already...
Yeah the problem is that I'm just not sure I want to take on the extra burden of supporting num-traits optionally. I think the best I can offer is unsealing the Float trait. Then you can write a wrapper type that impls Float in this crate with anything that impls the corresponding trait in num-traits.
Ah, that's unfortunate. I thought this would be okay considering the trait was already implemented in the previous versions...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Andrew!
First of all thanks a lot for developing this crate, I've been able to move some more of our data analysis pipeline to Rust thanks to it.
While I can understand why you want to get rid of the
num-traitsdependency in your context (at least, from what I got from the commit message of f19d626), it's actually super practical to have it available because you can depend on custom float types, the most interesting one for me beingf16from thehalfcrate to work with a reduced memory footprint. The drop ofnum-traitssupport prevented me from updating tov0.3.This PR keeps the best of both worlds by hiding the
num-traitsdependency behind a feature gate, which is disabled by default. Users like me who want to use theFloattrait fromnum-traitscan enable the feature, but by defaultkodamaremains without dependency.