fix(docker): copy and build @openwork/email package for den-api image#1825
Open
yashranaway wants to merge 1 commit into
Open
fix(docker): copy and build @openwork/email package for den-api image#1825yashranaway wants to merge 1 commit into
yashranaway wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@yashranaway is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
7ae1345 to
5fe03a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1804
Summary
packages/email/package.jsoninto the den image beforepnpm install --frozen-lockfileso the workspace package resolves.packages/emailsource after install and add a build step beforeden-dbandden-apiso the compileddist/exists when den-api imports@openwork/emailat runtime.@openwork/emailhas no workspace deps so it can build right afterutils.Verification
docker build -f packaging/docker/Dockerfile.den .not run from this branch (no Docker on the dev box); the diff matches the exact patch the reporter posted in the issue.grep '@openwork/email' ee/apps/den-api/package.jsonconfirms den-api lists the workspace dep, andpackages/email/package.jsonexports./dist/index.jsas the production entry, which makes the missing build step the failure path described in Dockerfile.den missing @openwork/email package — build fails #1804.Notes
packages/emailhas no workspace dependencies, so it can build independently ofden-db.