Skip to content

fix(den-api): build on Windows #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pascalandr wants to merge 1 commit into
base: dev
Choose a base branch
from
+14 −2
Open

fix(den-api): build on Windows #1890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ee/apps/den-api/scripts/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ const serviceDir = path.resolve(scriptDir, "..")
const repoRoot = path.resolve(serviceDir, "..", "..", "..")
const desktopPackagePath = path.join(repoRoot, "apps", "desktop", "package.json")
const generatedVersionPath = path.join(serviceDir, "src", "generated", "app-version.ts")
const pnpmCommand = process.platform === "win32" ? "pnpm.cmd" : "pnpm"
const pnpmCommand = "pnpm"
const useShellForPnpm = process.platform === "win32"
const fallbackAppVersion = "0.0.0"

function readDesktopVersion() {
Expand Down Expand Up @@ -40,13 +41,24 @@ function writeGeneratedVersionFile(latestAppVersion) {
)
}

function quoteShellArg(value) {
return `"${String(value).replace(/"/g, '\\"')}"`
}

function run(command, args) {
const result = spawnSync(command, args, {
const shellCommand = [command, ...args.map(quoteShellArg)].join(" ")
const result = spawnSync(useShellForPnpm ? shellCommand : command, useShellForPnpm ? [] : args, {
cwd: serviceDir,
env: process.env,
stdio: "inherit",
shell: useShellForPnpm,
})

if (result.error) {
console.error(result.error)
process.exit(1)
}

if (result.status !== 0) {
process.exit(result.status ?? 1)
}
Expand Down