test(app): add voice mode CDP audio check#1976
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/app/scripts/voice-cdp.mjs">
<violation number="1" location="apps/app/scripts/voice-cdp.mjs:203">
P2: After connection, WebSocket error/close events don't reject pending requests, so the test runner hangs if the target drops. Add a `close` listener that rejects all outstanding promises.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Member
Author
|
End-to-end Daytona proof added and verified. Latest verification command: Result:
Also added visible Voice Mode diagnostics in the panel for prod/mac failures:
Screenshot proof from the resulting settings page: |
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
benjaminshafii
added a commit
that referenced
this pull request
May 27, 2026
* test(app): add voice mode CDP audio check * fix(app): wait for voice CDP target readiness * fix(desktop): require explicit audio media permission * fix(desktop): keep fake media behind permission handler * test(app): capture voice CDP proof * fix(desktop): request mac microphone access for voice * fix(app): harden voice CDP runner
benjaminshafii
added a commit
that referenced
this pull request
May 27, 2026
* feat(app): combine browser and artifacts views and state * ignore: update download stats 2026-05-27 * feat(app): use static grain art avatars (#1970) * fix(den): restore org subscription TypeID prefix (#1974) * fix(app): resolve grain art avatars in electron builds (#1975) * test(app): add voice mode CDP audio check (#1976) * test(app): add voice mode CDP audio check * fix(app): wait for voice CDP target readiness * fix(desktop): require explicit audio media permission * fix(desktop): keep fake media behind permission handler * test(app): capture voice CDP proof * fix(desktop): request mac microphone access for voice * fix(app): harden voice CDP runner --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: ben <ben@prologe.io> Co-authored-by: Source Open <gh2@mcadam.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Daytona preflight result: passed. Audio getUserMedia succeeded with fake media, video getUserMedia failed with NotAllowedError, Electron target and OpenWork control API were ready.
Notes