Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions DiffPalReviewDevV1/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,26 +109,17 @@
"defaultValue": "false",
"helpMarkDown": "Pass --debug to DiffPal so provider and runtime diagnostics are printed."
},
{
"name": "mode",
"type": "string",
"label": "Publish modes",
"required": false,
"defaultValue": "",
"helpMarkDown": "Advanced comma-separated Azure DevOps publish modes. Overrides feedback when set."
},
{
"name": "feedback",
"type": "pickList",
"label": "Feedback",
"required": false,
"defaultValue": "balanced",
"defaultValue": "review",
"options": {
"summary": "Summary",
"balanced": "Balanced",
"inline": "Inline"
"review": "Review"
},
"helpMarkDown": "Review feedback shape. Summary posts status and one PR summary. Balanced and Inline publish Azure threads for all findings; blocking findings stay active and non-blocking findings are closed immediately."
"helpMarkDown": "Review feedback shape. Summary posts status and one PR summary. Review publishes Azure threads for findings; blocking findings stay active and non-blocking findings are closed immediately."
},
{
"name": "language",
Expand Down
15 changes: 3 additions & 12 deletions DiffPalReviewV1/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,26 +109,17 @@
"defaultValue": "false",
"helpMarkDown": "Pass --debug to DiffPal so provider and runtime diagnostics are printed."
},
{
"name": "mode",
"type": "string",
"label": "Publish modes",
"required": false,
"defaultValue": "",
"helpMarkDown": "Advanced comma-separated Azure DevOps publish modes. Overrides feedback when set."
},
{
"name": "feedback",
"type": "pickList",
"label": "Feedback",
"required": false,
"defaultValue": "balanced",
"defaultValue": "review",
"options": {
"summary": "Summary",
"balanced": "Balanced",
"inline": "Inline"
"review": "Review"
},
"helpMarkDown": "Review feedback shape. Summary posts status and one PR summary. Balanced and Inline publish Azure threads for all findings; blocking findings stay active and non-blocking findings are closed immediately."
"helpMarkDown": "Review feedback shape. Summary posts status and one PR summary. Review publishes Azure threads for findings; blocking findings stay active and non-blocking findings are closed immediately."
},
{
"name": "language",
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ base/head, and redacted CLI arguments before the review starts.
Set `debug: true` to pass `--debug` to DiffPal and enable provider/runtime
diagnostics. This is separate from Azure `System.Debug`.

With `feedback: balanced` or `feedback: inline`, DiffPal publishes Azure threads
With `feedback: review`, DiffPal publishes Azure threads
for all findings. Blocking findings stay active; non-blocking findings are
published as closed immediately. Findings without canonical file/line mapping to
current PR changes are skipped instead of publishing a broken file thread.
Expand Down Expand Up @@ -72,7 +72,7 @@ steps:
inputs:
diffpalVersion: 0.1.35
profile: ci
feedback: balanced
feedback: review
env:
OPENAI_API_KEY: $(OPENAI_API_KEY)
SYSTEM_ACCESSTOKEN: $(System.AccessToken)
Expand All @@ -95,7 +95,7 @@ steps:
displayName: DiffPal blocking review
inputs:
profile: ci
feedback: balanced
feedback: review
gate: true
blockOn: high
env:
Expand All @@ -121,7 +121,7 @@ steps:
displayName: DiffPal review with Copilot
inputs:
profile: ci
feedback: balanced
feedback: review
env:
GITHUB_TOKEN: $(GITHUB_TOKEN)
SYSTEM_ACCESSTOKEN: $(System.AccessToken)
Expand Down
2 changes: 1 addition & 1 deletion overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ steps:
- task: DiffPalReview@1
inputs:
profile: ci
feedback: balanced
feedback: review
gate: true
env:
SYSTEM_ACCESSTOKEN: $(System.AccessToken)
Expand Down
6 changes: 3 additions & 3 deletions scripts/smoke-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function runHandler(name, env) {
INPUT_BASE: "base-sha",
INPUT_HEAD: "head-sha",
INPUT_BLOCKON: "high",
INPUT_FEEDBACK: "balanced",
INPUT_FEEDBACK: "review",
SYSTEM_ACCESSTOKEN: "system-token",
...env
},
Expand All @@ -47,7 +47,7 @@ function runHandlerExpectFailure(name, env) {
INPUT_BASE: "base-sha",
INPUT_HEAD: "head-sha",
INPUT_BLOCKON: "high",
INPUT_FEEDBACK: "balanced",
INPUT_FEEDBACK: "review",
SYSTEM_ACCESSTOKEN: "system-token",
...env
},
Expand Down Expand Up @@ -510,7 +510,7 @@ function testExplainPrintsResolvedContext() {
INPUT_BASE: "",
INPUT_HEAD: "",
INPUT_BLOCKON: "high",
INPUT_FEEDBACK: "balanced",
INPUT_FEEDBACK: "review",
INPUT_EXPLAIN: "true",
SYSTEM_ACCESSTOKEN: "secret-token-value",
SYSTEM_PULLREQUEST_PULLREQUESTID: "123",
Expand Down
6 changes: 1 addition & 5 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -478,11 +478,7 @@ async function run(): Promise<void> {
if (gate) {
args.push("--gate");
}
const mode = input("mode");
addOptional(args, "--mode", mode);
if (!mode) {
addOptional(args, "--feedback", input("feedback") || "balanced");
}
addOptional(args, "--feedback", input("feedback") || "review");
addOptional(args, "--language", input("language"));
addOptional(args, "--instructions", input("instructions"));
addOptional(args, "--instructions-file", resolveInstructionsFile(input("instructionsFile")));
Expand Down