Skip to content

Settle the notepad prompt's answer inside act so the kill's removal timer wins #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dormouse-bot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Settle the notepad prompt's answer inside act so the kill's removal timer wins #585

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e7d2cd
Settle the notepad prompt's answer inside act so the kill's removal t…
dormouse-bot Sep 7, 2026
c1a5ec4
Scope the clickButton doc comment to the answer that starts the timer
dormouse-bot Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions lib/src/components/Wall.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1681,11 +1681,19 @@ describe('Wall on the Lath engine', () => {
return container.querySelector<HTMLElement>('[aria-labelledby="notepad-archive-failure-title"]');
}

function clickButton(label: string): void {
/** Answer the prompt and settle the closure it starts. `Close anyway` runs an async
* chain that ends on the two-phase kill's deferred removal timer, so the click's
* own async work is awaited BEFORE `flush()` registers the timer that has to fire
* after it. A bare `act(click)` leaves the two `setTimeout(0)`s racing: the
* removal is registered while the test awaits `flush()`, so it lands second and
* the leaf is still mid-fade when the assertion runs. (`Keep open` only shifts the
* prompt queue, so it needs no ordering — one helper still covers both.) */
async function clickButton(label: string): Promise<void> {
const button = Array.from(container.querySelectorAll<HTMLButtonElement>('button'))
.find((candidate) => candidate.textContent?.trim() === label);
expect(button, `no "${label}" button`).toBeDefined();
act(() => { button!.click(); });
await act(async () => { button!.click(); });
await flush();
}

/** The pane header's Kill button — a user-visible closure, which does prompt.
Expand Down Expand Up @@ -1853,9 +1861,7 @@ describe('Wall on the Lath engine', () => {
await clickHeaderKill('pane-a');
expect(archiveFailureModal()).not.toBeNull();
setBusy(true);
clickButton('Close anyway');
await flush();
await flush();
await clickButton('Close anyway');
expect(getNotes('pane-a')).toHaveLength(1);
expect(dispose).not.toHaveBeenCalled();
expect(container.querySelector('[data-lath-leaf="pane-a"]')).not.toBeNull();
Expand Down Expand Up @@ -1925,8 +1931,7 @@ describe('Wall on the Lath engine', () => {
act(() => { addPlainNote('pane-a', 'keep me'); });
await clickHeaderKill('pane-a');

clickButton('Keep open');
await flush();
await clickButton('Keep open');

expect(archiveFailureModal()).toBeNull();
expect(container.querySelector('[data-lath-leaf="pane-a"]')).not.toBeNull();
Expand All @@ -1942,8 +1947,7 @@ describe('Wall on the Lath engine', () => {
act(() => { addPlainNote('pane-a', 'expendable'); });
await clickHeaderKill('pane-a');

clickButton('Close anyway');
await flush();
await clickButton('Close anyway');

expect(archiveFailureModal()).toBeNull();
expect(container.querySelector('[data-lath-leaf="pane-a"]')).toBeNull();
Expand Down Expand Up @@ -1972,12 +1976,10 @@ describe('Wall on the Lath engine', () => {

// A's prompt is the one on screen; B's is behind it.
expect(archiveFailureModal()?.textContent).toContain('a could not be written');
clickButton('Keep open');
await flush();
await clickButton('Keep open');

expect(archiveFailureModal()?.textContent).toContain('b could not be written');
clickButton('Close anyway');
await flush();
await clickButton('Close anyway');

expect(archiveFailureModal()).toBeNull();
expect(container.querySelector('[data-lath-leaf="pane-a"]')).not.toBeNull();
Expand Down