docs(design): describe the Door as the two-button group it is - #595
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
1b7d2f2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e89b548b.mouseterm.pages.dev |
| Branch Preview URL: | https://docs-design-doors-current.mouseterm.pages.dev |
dormouse-bot
commented
Sep 8, 2026
dormouse-bot
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewing as a draft — flagging anything that looks worth a quick fix. Mark ready for a full review.
Both findings are on the two rewritten bullets; the role="group" / hover rewrite and the notepad-button description check out against Door.tsx, as do the two spec headings the new text points at.
…claim The leading browser-display icon is a pair (wide robot + presentation glyph, gap-0.5), with the robot dropped only for iframe, so 'glyph' singular understated the leading content. The Dimensions bullet also claimed the notepad button leaves the door's width unchanged; it adds ~22px unless max-w-[220px] truncates the title instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESIGN.md§5 Doors still describes the Door as it was before the notepad and browser-Surface work landed, so the one fileAGENTS.mdtells you to read before touching anytext-*/bg-*class on a Door is wrong about that component's structure. This updates the three stale bullets to matchlib/src/components/Door.tsx.Three claims that no longer hold:
role="group"wrapper holding one or two buttons — the title button reattaches and starts the drag, the notepad button does neither.docs/specs/notepad.md→ Notepad UI already states this correctly ("A Door is a wrapper carryingdata-door-idwith one or two buttons"), so DESIGN.md was the side that drifted; the new text points at that spec rather than restating its rule.px-2.5(10px)". The padding moved onto the inner buttons and now varies: the title button ispl-2.5withpr-2.5alone orpr-1when the notepad button follows, and the notepad button carriespl-0.5 pr-2.Also notes that the notepad button is the only part of a Door taking the standard
hover:bg-current/10wash — the "no decorative hover" rule still holds for the door itself.No test: this is a documentation-only change, and DESIGN.md carries no lint beyond the generic ones. Full
pnpm testis green on the branch head.Evidence
Door.tsxat61dbd293— outer element isrole="group"withdata-door-id; the title<button>haspl-2.5plusshowNotepad ? 'pr-1' : 'pr-2.5'; the notepad<button>haspl-0.5 pr-2 hover:bg-current/10;BrowserDisplayIconrenders ahead of the title.BrowserDisplayIconinlib/src/components/wall/BrowserDisplayIcon.tsxis a two-glyph cluster, not one glyph: aninline-flex gap-0.5span holdingAgentRobotIconplus the mode's presentation glyph, with the robot dropped foriframealone. The Content bullet says so.Timeline: the Door's notepad button landed 2026-09-04 (
2d0945a3,61dbd293) and the browser-display cluster 2026-09-03 (c7fa07d4); DESIGN.md's last edit is 2026-09-05 (c4d0b2b1) and touched other sections only, so the Doors entry was never carried forward.The
components.doorfront-matter token (padding: "0 10px") is left alone — it is the nominal design token for the component, not a per-button inventory, and changing it looked like overreach for a doc-accuracy fix.The second commit on this branch folds in the two findings this PR's own draft review raised: "glyph" singular understated the icon cluster, and the first draft of the Dimensions bullet wrongly claimed the notepad button leaves the door's width unchanged (it adds roughly 22px unless
max-w-[220px]truncates the title instead), so that clause is gone.