test(relay): say host, not burrow, where config means a hostname - #596
Draft
dormouse-bot wants to merge 1 commit into
Draft
test(relay): say host, not burrow, where config means a hostname#596dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
Deploying mouseterm with
|
| Latest commit: |
dde48fa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ad4bbb5e.mouseterm.pages.dev |
| Branch Preview URL: | https://docs-relay-config-test-host.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two spots in
relay/test/config.test.mjssay "burrow" where they mean a hostname, which reads as fallout from the Host→Burrow rename applying to prose it should not have.AGENTS.mdreserves the two words in opposite directions — "Host is reserved for the platform host, theHostheader, hostnames, and self-hosting" — so the current text says the wrong one of the pair.a blank DORMOUSE_BIND_HOST is treated as unset, not as an empty burrowis about the listen interface. A blank value is not "an empty burrow"; it is an empty host.DORMOUSE_ORIGIN is normalized to a bare originsays "a trailing slash, a path, or a capitalized burrow" about the case that lowercaseshttps://Dor.Example.TS.NET/. That is the origin's hostname, not a Burrow.Both are one-word edits; no assertion, input, or expectation changes. The surrounding uses of "Burrow" in the same file are correct and are left alone (
the/#pair?…QR a Burrow composes).No regression test: this changes only a test name and a comment, so there is nothing behavioural to pin.
node --checkpasses on the file and the two assertions it labels are untouched.Why this is worth fixing rather than leaving
docs/specs/security-remote.md→ "Credentials at rest" carries aFAIL IFabout "a credential the Host→Burrow rename retired", so the rename is recent enough that its over-applications are still findable. The test name in particular is what a reader sees in failure output, and "an empty burrow" points at the wrong subsystem entirely —DORMOUSE_BIND_HOSTis the Relay's listen interface and has nothing to do with a Burrow.I searched the rest of the tree for the same shape (
empty|capitalized|bare|local|target|upstream burrow,burrowname,burrow header,localburrow) and these two are the only hits; every other "Burrow" reads correctly as the role.