[rewrite] fix GradleBestPractices#2727
Closed
Pankraz76 wants to merge 1 commit into
Closed
Conversation
Pankraz76
changed the title
GradleBestPracticesGradleBestPractices
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
force-pushed
the
fix-GradleBestPractices
branch
from
5a7115d to
5547f17
Compare
Pankraz76
commented
Nov 17, 2025
| validateDistributionUrl=true | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionSha256Sum=72f44c9f8ebcb1af43838f45ee5c4aa9c5444898b3468ab3f4af7b6076c5bc3f |
Author
There was a problem hiding this comment.
| apply from: rootProject.file('gradle/rewrite.gradle') | ||
| apply from: rootProject.file('gradle/spotless-freshmark.gradle') | ||
|
|
||
| spotless { |
Author
There was a problem hiding this comment.
is this possible to move and merge with the dedicated project config?
or do we need this to be divided?
nedtwigg
requested changes
Nov 18, 2025
nedtwigg
left a comment
nedtwigg
left a comment
Member
There was a problem hiding this comment.
This is changing too many things at once. Please only change one thing at a time.
Comment on lines
-11
to
19
|
|
||
| apply from: rootProject.file('gradle/java-publish.gradle') | ||
| apply from: rootProject.file('gradle/changelog.gradle') | ||
| allprojects { | ||
| apply from: rootProject.file('gradle/error-prone.gradle') | ||
| apply from: rootProject.file('gradle/rewrite.gradle') | ||
| apply from: rootProject.file('gradle/spotless.gradle') | ||
| } | ||
| apply from: rootProject.file('gradle/changelog.gradle') | ||
| apply from: rootProject.file('gradle/java-publish.gradle') | ||
| apply from: rootProject.file('gradle/rewrite.gradle') | ||
| apply from: rootProject.file('gradle/spotless-freshmark.gradle') |
Member
There was a problem hiding this comment.
- before: java-publish, then changelog, then allprojects
- after: allprojects, then changelog, then java-publish
That's a risky change. I think they depend on each other, but it takes time to confirm, and we won't notice it's broken until a publish fails. Try to make your PR's more focused on a single change and they are easier to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.
Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)