Integrate adocfmt for AsciiDoc formatting#2960
Merged
Merged
Conversation
nedtwigg
requested changes
Jun 5, 2026
nedtwigg
left a comment
nedtwigg
left a comment
Member
There was a problem hiding this comment.
Looks great! Needs a minor change around the default paths
Contributor
Author
|
@nedtwigg Done |
nedtwigg
approved these changes
Jun 8, 2026
Member
|
Thanks for the great PR! It'll get released when the other PRs in the pipeline either get merged or long-term blocked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @nedtwigg, this is a fresh PR for AsciiDoc support, following up on the earlier
one that we closed.
I took your feedback to heart: the formatting logic now lives in its own library,
org.drjekyll:adocfmt:0.2.0, published on Maven Central. This PR thereforecontains only the thin glue code, an
AdocfmtStepinlibthat resolves thelibrary via
JarStateand reflection (the same approach asKtfmtStepandGoogleJavaFormatStep), plus the Gradle and Maven wiring. The implementation andthe harness are fully decoupled now, and
libgains no new compile dependency.Thanks again for the patience and the clear guidance earlier. It led to a much
better result.