Adding default factory to message type#46
Open
jacantwell wants to merge 2 commits intomainfrom
Open
Conversation
jacantwell
requested review from
FreddyWordingham,
JDonaldM,
alexander-mead and
cariad
as code owners
Contributor
|
I personally don't mind when a class has required arguments. I'm not hungry for this change, so I'll leave it for someone else to approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may be a bad idea so doesnt need to go in. Sometimes its annoying always have to pass a datetime when creating a message; this sets the fault value for message to the time at creation of the instance.