Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion tests/test_embeddings.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def test_text_embeddings_config_raise_missing(text_embeddings_config_data: dict)

@pytest.mark.parametrize(
"embeddings_provider_field, field",
[("openai", "model"), ("openai", "ollama_url"), ("ollama", "openai_api_key")],
[("openai", "ollama_url"), ("ollama", "openai_api_key")],
indirect=["embeddings_provider_field"],
)
def test_text_embeddings_config_optional(text_embeddings_config_data: dict, field: str):
Expand All @@ -57,6 +57,28 @@ def test_text_embeddings_config_optional(text_embeddings_config_data: dict, fiel
assert text_embeddings_config.model_dump()[field] is None


@pytest.mark.parametrize(
"text_embeddings_config_data",
["openai", "ollama"],
indirect=True,
)
def test_text_embeddings_config_default_model(text_embeddings_config_data: dict):
"""Test that the default model is set correctly when not specified."""

# Remove the model field
del text_embeddings_config_data["model"]

# Instantiate a TextEmbeddingsConfig object
text_embeddings_config = TextEmbeddingsConfig(**text_embeddings_config_data)

# Check that the model field is set to the default value
provider = text_embeddings_config_data["provider"]
if provider == "openai":
assert text_embeddings_config.model == "text-embedding-ada-002"
elif provider == "ollama":
assert text_embeddings_config.model == "nomic-embed-text"


@pytest.mark.parametrize(
"embeddings_provider_field, field",
[("openai", "openai_api_key"), ("ollama", "ollama_url")],
Expand Down
11 changes: 11 additions & 0 deletions uncertainty_engine_types/embeddings.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,14 @@ def check_provider(cls, values):
):
raise ValueError("openai_api_key must be provided for 'openai' provider.")
return values

@model_validator(mode="before")
@classmethod
def check_model(cls, values):
model = values.get("model", None)
provider = values.get("provider")
if provider == TextEmbeddingsProvider.OLLAMA.value and not model:
values["model"] = "nomic-embed-text"
if provider == TextEmbeddingsProvider.OPENAI.value and not model:
values["model"] = "text-embedding-ada-002"
return values