Upd pages for submit#1197
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughAdds Community and Extract top-level sections: navigation entries, Express routes and Nunjucks views, mounts the routes, updates templates to surface the links site-wide, adjusts the landing masthead and CTA, and adds an ChangesCommunity and Extract Navigation Sections
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/views/community.html`:
- Around line 7-15: Remove the two empty <h1 class="govuk-heading-xl"> elements
and fix the mismatched anchor so the "Community" heading remains a single <h1>
and the descriptive text is properly wrapped inside the link and surrounding
spans; locate the elements with class "govuk-heading-xl" and the anchor
referencing "https://opendigitalplanning.org/about" and change the markup so
there is only one <h1 class="govuk-heading-xl">Community</h1>, the anchor
contains the linked span text ("get involved with community events and
discussions"), and no stray closing </a> remains, ensuring correct nesting and
valid HTML structure.
In `@src/views/extract.html`:
- Around line 7-27: The template contains two empty top-level headings and an
unmatched closing anchor: remove the empty <h1 class="govuk-heading-xl"></h1>
elements (the ones before the main title and at the end) and delete the stray
</a> so the "Find out more about extract" link is correctly formed (ensure the
<a> wraps only the span with class "govuk-body" and is properly opened/closed);
keep the single meaningful <h1 class="govuk-heading-xl">Extract your data</h1>
for an accessible heading structure.
In `@src/views/landing.html`:
- Line 37: Fix the typo in the user-facing paragraph that reads "Planning data
aims to make land and housing data easier to find, use and trust. We take the
data you provide and standardise it in a consistant format." by replacing
"consistant" with "consistent" in the landing view HTML paragraph containing
that sentence.
- Around line 25-34: The masthead currently nests a <ul> inside a <p> (the
element with class app-masthead__description), which is invalid HTML; replace
the paragraph wrapper with a block container (e.g., a div) that preserves the
same classes (app-masthead__description govuk-body-l govuk-!-margin-bottom-4)
and keep the existing <ul class="govuk-list govuk-list--bullet
govuk-list--spaced app-masthead govuk-body-l"> and its <li> items unchanged so
the list is no longer nested inside a paragraph and
rendering/assistive-technology behavior is correct.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 4179ed2d-1416-476c-bc53-5f9474fd320e
📒 Files selected for processing (21)
src/filters/getNavigationLinks.jssrc/routes/community.jssrc/routes/extract.jssrc/serverSetup/routes.jssrc/views/accessibility.htmlsrc/views/community.htmlsrc/views/cookies.htmlsrc/views/error.htmlsrc/views/extract.htmlsrc/views/landing.htmlsrc/views/organisations/dataset-overview.htmlsrc/views/organisations/datasetTaskList.htmlsrc/views/organisations/dataview.htmlsrc/views/organisations/find.htmlsrc/views/organisations/get-started.htmlsrc/views/organisations/http-error.htmlsrc/views/organisations/issueDetails.htmlsrc/views/organisations/issueTable.htmlsrc/views/organisations/overview.htmlsrc/views/privacy-notice.htmltest/PageObjectModels/landingPage.js
Ben-Hodgkiss
had a problem deploying
to
development
GitHub Actions
Failure
Removed duplicate list of service usage instructions and adjusted formatting.
Ben-Hodgkiss
had a problem deploying
to
development
GitHub Actions
Failure
Ben-Hodgkiss
previously approved these changes
Jun 3, 2026
…d/submit into upd-pages-for-submit
Ben-Hodgkiss
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update to the SUBMIT repository to reflect user community feedback
What type of PR is this? (check all applicable)
Related Tickets & Documents
#1193
digital-land/digital-land#634
QA Instructions, Screenshots, Recordings
Before
After
New Landing page:
New Community Tab
New Community Page:
## Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
New Extract Tab/ Page:
QA sign off
[optional] Are there any post-deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?
Summary by CodeRabbit
New Features
UI/UX Updates
Content
Tests