Open
Conversation
nuxion
reviewed
Jun 22, 2021
Contributor
nuxion
left a comment
nuxion
left a comment
There was a problem hiding this comment.
Muy bien el tp. Bien el apartado de tecnologia respecto a electron.
Respecto a los comentarios en el repositorio:
lo ideal es pensar git como una bitacora o diario que en algun momento va ser leido por uno u otro miembro del grupo, por ende los comentarios deben tener sentdio en relacion al codigo:
af4331 Se agregan referencias
33aa34 Se corrige links en las referencias
...
Lo mismo con el pull request, lo recomendable es introducir un texto que englobe los cambios:
Estudio sobre Discord. Tp1
Respecto al meno de git como herramienta, esta muy bien!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.