add bidirectional console RPC support - #291
Merged
Merged
Conversation
The DomainOpenConsole RPC method is generated only with a read stream, even though it actually supports writing. Add a special case to allow go-libvirt users to utilize the write stream. Continue to generate the existing method as-is to avoid breaking API compatibility.
DulioCagg
approved these changes
Jun 9, 2026
DulioCagg
left a comment
DulioCagg
left a comment
There was a problem hiding this comment.
Honestly I don't understand very well this code, but it LGTM
connorkuehl
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the
DomainOpenConsole()RPC is only annotated only with@readstream,go-libvirtdoes not generate a anio.Writerfor callers to use. Add a special case which results in aDomainOpenConsoleBidirectionalto also be written.