Refactor notification#32
Open
ArtemAntoshyk wants to merge 2 commits into
Open
Conversation
Short forms of functions were used instead of explicitly specifying return types.. Optimized code where possible for better readability and compactness.. Added indents to improve readability.
wert2all
reviewed
May 12, 2024
| icon = "\uD83D\uDE1E", | ||
| title = "На жаль, сталася помилка", | ||
| description = "Дані не зчитано. Втрачено зв’язок з картою або сталася помилка при зчитуванні", | ||
| title = "На жаль, сталася помилка😒", |
There was a problem hiding this comment.
there are controversial adding emoji to government application.
| class PinHelperImpl @Inject constructor( | ||
| private val biometric: Biometric, | ||
| private val settingsRepository: AppSettingsRepository, | ||
| private val settingsRepository: AppSettingsRepository |
There was a problem hiding this comment.
Adding trailing comma is one of development technique. Maybe should to apply this changes by adding a rule of static linters like a detekt, ktlint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed errors in the designer (extra comma removed).. Short forms of functions were used instead of explicitly specifying return types.. Optimized code where possible for better readability and compactness.. Added indents to improve readability.
Extends comments