Fix Core update health checks and rollback - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core updates on a public dashboard could reject a healthy API because Node fetch replaced the required public Host header with the loopback address. A failed API startup could also remove the transient backend unit, preventing rollback from stopping that already absent service.
Use Node's HTTP transport for bounded, cancellable health requests that preserve the public Host and recovery nonce. Permit an absent service during drain while retaining failures for a loaded service. Add regression coverage for public-host health checks, response limits, cancellation and both rollback cases.
Validation:
npm run check, all 114 unit tests, all 132 integration tests, the production build, and GitHub checks (including owner Updates browser checks) passed. An isolated native rehearsal passed public-host Core health checks, real service activation, failed-health rollback with an already collected backend, and restoration of the initial split migration. No published artifact is modified by this PR.