Verify Paycom immediately after saving credentials - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving a first-time Paycom connection currently leaves it Not verified until a DSP runtime becomes available for onboarding. Start the DSP broker's asynchronous verification immediately after the confirmed vault save, and let onboarding use that same check before starting hourly workforce sync.
The companion DSP PR #3 makes Paycom use the same connection status as Settings and open the workforce workspace while sync setup continues. This PR also fixes the synthetic browser preview to consume an explicitly installed DSP test package while retaining independent Core-only checks.
Validation passed: 138 Core unit tests, 139 integration tests against the companion DSP, 36 targeted enrollment/onboarding/vault tests, source checks and a production frontend/development artifact build. Twenty browser regression tests cover automatic save verification, desktop/mobile connection consistency, setup retry and completion, uncertain save handling, optional setup, saved workforce, timecards and sync controls. Provider responses are synthetic; no real Paycom login was attempted.
Browser QA used Playwright and Chromium because the Browser plugin is unavailable. The isolated Settings/Paycom flow passed at desktop and 390×844 mobile size: correct page identity, populated content, no framework overlay, no unexpected console errors, no horizontal overflow, and screenshots of checking/connected/workforce-preparation states. All three independent Core Updates browser checks also passed with the DSP test package removed. GitHub Core checks passed on ff6dad4.
No live services or DSP data were changed. Merge requires the owner's explicit chat approval; publication and installation remain separate.