Recover DSP deletion blocked by SQLite backup sidecars - #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permanent DSP deletion can remain stuck in backup cleanup after a read-only SQLite connection adds an empty WAL and shared-memory file to a retained snapshot. The backup worker also drops the underlying error code, leaving only a generic deletion failure.
Recover only recognized SQLite sidecars added after the snapshot when removing them reproduces the original complete checksum and byte count. Recheck file identity and contents before removal, keep restore validation strict, and preserve safe failure codes across the backup worker boundary. Any changed database, nonempty WAL, unsafe file, or unrelated addition still blocks deletion. Interrupted cleanup remains retryable.
Validation:
invalid_requeston both this branch and unchanged main; the failure is in the existing plugin-state restore call.No production backups, DSPs, or services have been changed. This is a Core-only fix.