Add independent DSP checks and guarded release workflow - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DSP checks now obtain a verified package bundle in a separate job from an exact Core commit, then bootstrap and test the DSP without a Core source checkout in its build job. Each run rebuilds the bundle, so development does not depend on an expired artifact or an early product release.
The manual DSP release workflow requires a published Core dependency bundle pinned by URL and SHA-256. It uses the SDK publication tooling from Core PR #1 and publishes independently of production activation.
Hosted checks prepare trusted Node and Chrome paths on a disposable runner, run a blank native-window smoke check, and execute the complete DSP suite sequentially to avoid competing browser startup work. Production trust checks remain unchanged. The CAPTCHA fixture waits for the new document to load before inspecting its state, fixing a stale-page race exposed by hosted execution.
Validation: 323 DSP tests and three dependency-lock tests pass locally; source checks, TypeScript/plugin build, actionlint and public source scanning pass. GitHub checks passed for
0174cf01543af893cdb2f757ce3dd3de8a963dbc. Publication with real GitHub attestations remains pending an owner-requested release.Merge requires explicit chat approval. This PR does not create a release, deploy the permanent Dev DSP or change production.
Related Core PR: dillonlille/dispatch-core#1