Stop Diagnostics monitoring when nobody is viewing it - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostics now checks storage and backups when the owner opens the page, then reuses that snapshot during CPU/RAM polling. Elapsed time does not trigger another storage scan, and old snapshots retain their measurement timestamp without being mislabeled as a failed scan.
CPU/RAM polling stops when the page is hidden or closed. Owner-scoped viewer leases keep a shared storage scan alive while someone is watching; leaving sends a CSRF-protected close request, and the final viewer's exit cancels further scan work. Lost viewers expire after seven seconds without requiring a background monitoring timer. Returning starts a fresh scan and resets the CPU baseline.
Validation: both product builds, resource/cache/cancellation/multiple-viewer tests, API authorization and redaction checks, and browser checks for live polling, one scan per visit, leaving/reopening, hidden tabs, old snapshots, mobile layout and close-request authorization. Full CI runs from a fresh assembly. No release or live installation is included.