Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions frontend/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { CalendarView } from './pages/CalendarView';
import { TodoView } from './pages/TodoView';
import { TodoDetailView } from './pages/TodoDetailView';
import { TaskBoard } from './pages/TaskBoard';
import { TerminalView } from './pages/TerminalView';
import { ErrorBoundary } from './components/ErrorBoundary';
import { MobileShell } from './components/MobileShell';
import { DesktopShell } from './components/DesktopShell';
Expand Down Expand Up @@ -168,6 +169,22 @@ export function App() {
</ProtectedRoute>
}
/>
<Route

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 style: The /terminal routes are not wrapped in <PageRoute> unlike all other protected pages (/inbox, /calendar, /todos, /tasks, /files). On desktop, the terminal view will not render inside the DesktopShell layout, losing the nav sidebar. This may be intentional for a full-screen terminal experience, but is inconsistent with the other pages. [fixable]

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 regressions: The terminal routes lack an ErrorBoundary wrapper, unlike the chat and file viewer routes. If xterm.js throws during initialization (e.g., WebGL context failure on some mobile devices), the entire app will crash instead of showing a fallback. [fixable]

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 regressions: Terminal routes are not wrapped in <PageRoute> unlike every other non-chat page (Inbox, Calendar, Todos, Tasks, Files). On desktop, this means clicking 'Terminal' in DesktopNav navigates away from the desktop shell layout, losing the sidebar nav. If a full-screen terminal is intended (like ChatView), the route should use a pattern analogous to <ChatRoute>. Otherwise, wrap in <PageRoute> for consistency. [fixable]

path="/terminal"
element={
<ProtectedRoute>
<TerminalView />

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 style: Terminal routes are not wrapped in <ErrorBoundary> unlike the similar full-screen ChatRoute (line 104). An unhandled error in xterm.js or the WS connection would crash the React tree. Wrapping in <ErrorBoundary> matches the existing pattern. [fixable]

</ProtectedRoute>
}
/>
<Route
path="/terminal/:sessionId"
element={
<ProtectedRoute>
<TerminalView />
</ProtectedRoute>
}
/>
</Routes>
</MobileShell>
</BrowserRouter>
Expand Down
1 change: 1 addition & 0 deletions frontend/src/components/DesktopNav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export function DesktopNav() {
},
{ label: 'Calendar', path: '/calendar', match: (p) => p.startsWith('/calendar') },
{ label: 'Files', path: '/files', match: (p) => p.startsWith('/files') },
{ label: 'Terminal', path: '/terminal', match: (p) => p.startsWith('/terminal') },
];

return (
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/MobileShell.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { useLocation } from 'react-router-dom';
import { useIsDesktop } from '../hooks/useMediaQuery';
import { TabBar } from './TabBar';

const HIDE_TAB_BAR = ['/login', '/chat'];
const HIDE_TAB_BAR = ['/login', '/chat', '/terminal'];

function shouldHideTabBar(pathname: string): boolean {
return HIDE_TAB_BAR.some((p) => pathname === p || pathname.startsWith(p + '/'));
Expand Down
13 changes: 12 additions & 1 deletion frontend/src/components/TabBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ export function TabBar() {
},
];

const isMoreActive = ['/tasks', '/files'].some((p) => location.pathname.startsWith(p));
const isMoreActive = ['/tasks', '/files', '/terminal'].some((p) =>
location.pathname.startsWith(p),
);

return (
<>
Expand All @@ -64,6 +66,15 @@ export function TabBar() {
>
Files
</button>
<button
className="tab-bar-more-item"
onClick={() => {
navigate('/terminal');
setMoreOpen(false);
}}
>
Terminal
</button>
<div className="tab-bar-more-divider" />
<button
className="tab-bar-more-item"
Expand Down
159 changes: 159 additions & 0 deletions frontend/src/components/Terminal.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,159 @@
/** Terminal — xterm.js wrapper with mobile keyboard toolbar. */

import { useRef, useEffect, useCallback, useState } from 'react';
import { Terminal as XTerm } from '@xterm/xterm';
import { FitAddon } from '@xterm/addon-fit';
import { WebLinksAddon } from '@xterm/addon-web-links';
import '@xterm/xterm/css/xterm.css';

interface TerminalProps {
onData: (data: string) => void;
onResize: (cols: number, rows: number) => void;
/** Ref callback — parent calls write() to push PTY output into the terminal. */
termRef: React.MutableRefObject<{ write: (data: string) => void } | null>;
}

export function Terminal({ onData, onResize, termRef }: TerminalProps) {
const containerRef = useRef<HTMLDivElement>(null);
const xtermRef = useRef<XTerm | null>(null);
const fitRef = useRef<FitAddon | null>(null);
const [ctrlActive, setCtrlActive] = useState(false);

useEffect(() => {
if (!containerRef.current) return;

const xterm = new XTerm({
cursorBlink: true,
fontSize: 14,
fontFamily: 'Menlo, Monaco, "Courier New", monospace',
theme: {
background: '#1a1a2e',
foreground: '#e0e0e0',
cursor: '#e0e0e0',
selectionBackground: '#3a3a5e',
black: '#1a1a2e',
red: '#ff6b6b',
green: '#51cf66',
yellow: '#ffd43b',
blue: '#74c0fc',
magenta: '#cc5de8',
cyan: '#66d9e8',
white: '#e0e0e0',
brightBlack: '#4a4a6e',
brightRed: '#ff8787',
brightGreen: '#69db7c',
brightYellow: '#ffe066',
brightBlue: '#91d5ff',
brightMagenta: '#da77f2',
brightCyan: '#99e9f2',
brightWhite: '#ffffff',
},
allowProposedApi: true,
scrollback: 5000,
});

const fit = new FitAddon();
fitRef.current = fit;
xterm.loadAddon(fit);
xterm.loadAddon(new WebLinksAddon());

xterm.open(containerRef.current);

// Delay fit to ensure container has layout dimensions
requestAnimationFrame(() => {
fit.fit();
onResize(xterm.cols, xterm.rows);
});

xterm.onData((data) => {
onData(data);
});

// Expose write method to parent
termRef.current = {
write: (data: string) => xterm.write(data),
};

xtermRef.current = xterm;

const handleResize = () => {
fit.fit();
onResize(xterm.cols, xterm.rows);
};

window.addEventListener('resize', handleResize);

// Also re-fit when keyboard opens/closes on mobile
const resizeObserver = new ResizeObserver(() => {
requestAnimationFrame(() => {
fit.fit();
onResize(xterm.cols, xterm.rows);
});
});
if (containerRef.current) {
resizeObserver.observe(containerRef.current);
}

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 style: The eslint-disable-next-line react-hooks/exhaustive-deps suppresses the warning for the mount-only effect that captures onData, onResize, and termRef. These are stable refs/callbacks by design, but the suppression hides potential future regressions if the API changes. Consider listing the stable dependencies explicitly (they won't cause re-runs) to remove the lint suppression. [fixable]

return () => {
window.removeEventListener('resize', handleResize);
resizeObserver.disconnect();
termRef.current = null;
xterm.dispose();
};

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 style: The eslint-disable-next-line comment suppresses react-hooks/exhaustive-deps for the entire effect. The props (onData, onResize, termRef) are intentionally excluded because they're expected to be stable refs/callbacks. This is a known pattern but could break silently if a caller passes unstable callbacks. Consider documenting this contract in the TerminalProps interface.

// eslint-disable-next-line react-hooks/exhaustive-deps

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 style: The eslint-disable-next-line react-hooks/exhaustive-deps suppression on the empty-deps useEffect is acceptable here since the intent is mount-once behavior and all callbacks are stable. However, this could be made explicit by extracting the xterm setup into a custom hook or documenting which deps are intentionally omitted.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 style: The eslint-disable-next-line react-hooks/exhaustive-deps suppression hides missing deps (onData, onResize, termRef). This is actually correct here — the effect intentionally runs once and captures the initial callbacks, with the parent using stable refs. A brief comment explaining WHY the deps are intentionally empty would be clearer than a blanket eslint-disable. [fixable]

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 unsafe_assumptions: The useEffect has an empty dependency array with // eslint-disable-next-line react-hooks/exhaustive-deps, but it closes over onData, onResize, and termRef. If the parent re-renders with new callback references (which happens when writeInput/resize change), the Terminal component will use the stale initial callbacks. The ref-forwarding pattern in useTerminal mitigates this for onData, but onResize from useTerminal.resize is a useCallback with [send] deps — if send ever changed, onResize would go stale here. [fixable]

}, []);

const sendKey = useCallback(
(key: string) => {
if (ctrlActive) {
// Convert to control character (Ctrl+A = \x01, Ctrl+C = \x03, etc.)
const code = key.toUpperCase().charCodeAt(0) - 64;
if (code > 0 && code < 32) {
onData(String.fromCharCode(code));
}
setCtrlActive(false);
} else {
onData(key);
}
xtermRef.current?.focus();
},
[ctrlActive, onData],
);

const toolbarKeys = [
{ label: 'Esc', key: '\x1b' },
{ label: 'Tab', key: '\t' },
{ label: 'Ctrl', key: '__ctrl__' },
{ label: '\u2191', key: '\x1b[A' },
{ label: '\u2193', key: '\x1b[B' },
{ label: '\u2190', key: '\x1b[D' },
{ label: '\u2192', key: '\x1b[C' },
{ label: '|', key: '|' },
{ label: '/', key: '/' },
{ label: '~', key: '~' },
];

return (
<div className="terminal-container">
<div className="terminal-xterm" ref={containerRef} />
<div className="terminal-toolbar">
{toolbarKeys.map((tk) => (
<button
key={tk.label}
className={`terminal-toolbar-key${tk.key === '__ctrl__' && ctrlActive ? ' terminal-toolbar-key--active' : ''}`}
onPointerDown={(e) => {
e.preventDefault(); // Don't steal focus from xterm
if (tk.key === '__ctrl__') {
setCtrlActive((v) => !v);
} else {
sendKey(tk.key);
}
}}
>
{tk.label}
</button>
))}
</div>
</div>
);
}
Loading
Loading