Skip to content

fix(ui): opaque session banner + header stacking context #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimakis merged 3 commits into from
Jul 4, 2026
Merged

fix(ui): opaque session banner + header stacking context #404

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b382eec
fix(ui): opaque session banner + header stacking context
dimakis Jun 27, 2026
47242a9
fix(ui): close 1px gap between header and session banner
dimakis Jun 27, 2026
5a6ff48
fix(ui): box-shadow bridge between header and session banner
dimakis Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions frontend/src/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1475,6 +1475,9 @@ textarea:focus {
background: var(--surface);
border-bottom: 1px solid var(--border);
flex-shrink: 0;
position: relative;
z-index: 20;
box-shadow: 0 4px 0 0 var(--surface);
transition:
max-height 0.2s,
padding 0.2s,
Expand Down Expand Up @@ -1666,7 +1669,7 @@ textarea:focus {
flex: 1;
overflow-y: auto;
-webkit-overflow-scrolling: touch;
padding: var(--space-4) var(--space-3);
padding: 0 var(--space-3) var(--space-4);

@dimakis dimakis Jul 4, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 regressions: Removing top padding from .chat-messages (was var(--space-4), now 0) means that when no session banner is rendered (SessionBanner returns null when bootContext and sessionContext are both absent), the first message sits flush against the header. Combined with the new 4px box-shadow on .chat-header (z-index 20), the top ~4px of the first message will be visually obscured. Consider adding a small top margin/padding to .chat-messages children or using a CSS :first-child rule to restore spacing when the banner is absent. [fixable]

display: flex;
flex-direction: column;
gap: var(--space-3);
Expand Down Expand Up @@ -2427,8 +2430,10 @@ textarea:focus {
position: sticky;
top: 0;
z-index: 10;
margin: -1px calc(-1 * var(--space-3)) 0;

@dimakis dimakis Jul 4, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 style: The negative horizontal margin calc(-1 * var(--space-3)) makes the banner full-bleed on mobile where .chat-messages uses var(--space-3) horizontal padding, but on desktop the container padding is var(--space-6) (2rem) while the banner only pulls back 0.75rem. The banner won't reach the container edges on desktop. This may be fine visually, but if full-bleed is intended across breakpoints, the negative margin should use a CSS variable or be overridden in the desktop media query. [fixable]

padding: 0 var(--space-3);
border-bottom: 1px solid var(--border);
background: var(--bg-primary);
background: var(--surface);
}

.session-banner-header {
Expand Down
Loading