Replace string-based audio format handling with AudioFormat enum#5
Merged
Conversation
dimdasci
commented
Jun 29, 2025
dimdasci
commented
Owner
- Created AudioFormat enum in formats.py with MP3, WAV, FLAC, AAC, OGG, M4A, UNKNOWN
- Updated utils.get_audio_properties to return AudioFormat
- Modified core.SoundFile to use AudioFormat throughout
- Made convert_format/convert require explicit target_format: AudioFormat
- Updated all code, tests, and documentation to use AudioFormat
- Added AudioFormat to public API via init.py and all
- All tests pass and code meets style requirements
- Created AudioFormat enum in formats.py with MP3, WAV, FLAC, AAC, OGG, M4A, UNKNOWN - Updated utils.get_audio_properties to return AudioFormat - Modified core.SoundFile to use AudioFormat throughout - Made convert_format/convert require explicit target_format: AudioFormat - Updated all code, tests, and documentation to use AudioFormat - Added AudioFormat to public API via __init__.py and __all__ - All tests pass and code meets style requirements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.