Draft
Conversation
… jeff/fix/rosnav3
…o jeff/fix/rosnav3
…ll.sh - Include docker_build_ssh in build hash so toggling SSH triggers rebuild - Capture stderr on build failure for actionable error messages - Change _get_image_build_hash to take cfg instead of raw docker_bin str - Remove private names from __all__ in docker_build.py - Add helpful TypeError when DockerModule payload isn't JSON-serializable - Replace ThreadPoolExecutor.map in start_all_modules with safe_thread_map to surface all failures via ExceptionGroup instead of losing all but first - Restore scripts/install.sh and README.md (accidentally removed) - Add intent comments on deploy_parallel and safe_thread_map design choices
…ll.sh - Include docker_build_ssh in build hash so toggling SSH triggers rebuild - Capture stderr on build failure for actionable error messages - Change _get_image_build_hash to take cfg instead of raw docker_bin str - Remove private names from __all__ in docker_build.py - Add helpful TypeError when DockerModule payload isn't JSON-serializable - Replace ThreadPoolExecutor.map in start_all_modules with safe_thread_map to surface all failures via ExceptionGroup instead of losing all but first - Restore scripts/install.sh and README.md (accidentally removed) - Add intent comments on deploy_parallel and safe_thread_map design choices
…o jeff/fix/rosnav3
…o jeff/fix/rosnav3
Keep the original filename to reduce PR diff size.
The "Outer" suffix was unclear — "Proxy" better describes its role as a host-side proxy that forwards RPCs to the real module inside the container. Also switches _is_built from a bare bool to threading.Event for thread safety.
…o jeff/fix/rosnav3
…nto jeff/fix/rosnav3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT: Docker PR needs to be reviewed first
File change count is so high because g1 blueprints were redone
Problem
G1 parity with Go2
Solution
Breaking Changes
How to Test
Contributor License Agreement