Skip to content

Add Base L2 remote chain support#18

Merged
dominicletz merged 3 commits into
mainfrom
feat/base-chain-support
Jul 15, 2026
Merged

Add Base L2 remote chain support#18
dominicletz merged 3 commits into
mainfrom
feat/base-chain-support

Conversation

@dominicletz

Copy link
Copy Markdown
Member

Summary

  • Add Chains.Base with registry and developer fleet addresses, and register it in RemoteChain production chain list.
  • Derive Contract.NodeRegistry chain ID from DiodeClient.Shell.Moonbeam instead of a hardcoded constant, with commented post-freeze Base migration addresses.
  • Bump diode_client to pick up DiodeClient.Shell.Base support and add regression tests for Base chain metadata.

Test plan

  • DIODE_MINIMAL_TEST=1 mix test --no-start test/chains/base_test.exs
  • mix compile on a clean checkout
  • Verify Base RPC/WS endpoints resolve via RemoteChain.ChainList in a running node

Register Chains.Base in RemoteChain, derive NodeRegistry chain_id from diode_client Shell metadata, and bump diode_client for Shell.Base support.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the Base L2 chain by introducing the Chains.Base module, updating the remote chains list, and adding corresponding tests. It also refactors Contract.NodeRegistry to dynamically fetch the Moonbeam chain ID. The reviewer noted that a commented-out line in node_registry.ex uses an incorrect module reference (Shell.Base instead of DiodeClient.Shell.Base), which would cause compilation issues if uncommented.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/contract/node_registry.ex Outdated
Restore Moonriver for movr_balance, fix Base block interval units, align NodeRegistry chain_id with Chains.Moonbeam, and simplify Base tests.
@dominicletz
dominicletz merged commit b7d0483 into main Jul 15, 2026
2 checks passed
@dominicletz
dominicletz deleted the feat/base-chain-support branch July 15, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant