Skip to content

fixing multithread issues on windows #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GavinFAW wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixing multithread issues on windows #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/pitch_interval.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ std::string intervalFillStr(const std::string& s, int n) {
static std::unordered_map<std::string, Interval> intervalCache;

// Arrays and constants - match TypeScript implementation
const std::vector<int> SIZES = {0, 2, 4, 5, 7, 9, 11};
const std::string TYPES = "PMMPPMM";
const std::array<int,7> SIZES = {0, 2, 4, 5, 7, 9, 11};
constexpr std::array<char, 7> TYPES = { 'P','M','M','P','P','M','M' };

// Define NoInterval - exactly like in TypeScript
const Interval NoInterval = Interval();
Expand Down Expand Up @@ -246,17 +246,17 @@ Interval interval(const std::string& src, bool useCache) {
}

// Check cache first
if (useCache && intervalCache.find(src) != intervalCache.end()) {
return intervalCache[src];
}
// if (useCache && intervalCache.find(src) != intervalCache.end()) {
// return intervalCache[src];
// }

// Parse string - using renamed function
auto result = parseInterval(src);

// Cache result if valid
if (useCache && !result.empty) {
intervalCache[src] = result;
}
// if (useCache && !result.empty) {
// intervalCache[src] = result;
// }

return result;
}
Expand Down