Update ContractInfoTLVs in test vectors to use pre-images#125
Open
nkohen wants to merge 3 commits intodiscreetlogcontracts:masterfrom
Open
Update ContractInfoTLVs in test vectors to use pre-images#125nkohen wants to merge 3 commits intodiscreetlogcontracts:masterfrom
nkohen wants to merge 3 commits intodiscreetlogcontracts:masterfrom
Conversation
Tibo-lg
reviewed
Dec 21, 2020
| @@ -47,9 +47,9 @@ | |||
| "payoutAddress" : "bcrt1qx2rdxteeum3suhqvxgzwvyljtjjv5nd4g24vuy" | |||
| } | |||
| }, | |||
| "offer" : "a71a0006226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910ffda71050582e987a29cec9b8fd24a03935b415c9a2afa88059f31c3fcd1e013b8a698316000000000bebc200c6f1e739d6321d0728b8fa72b9005af83d30479aa68d76be8245ce5f06138fe60000000000000000fda71240937ce52b968e2bf92253fda2932ffdcf41b4a4a4840b1ae6dfb086fc0c11e90d5966a509a8244c6fde25ed5eb677b2fc79e2889371bff864790ff6af8055966d03b221c54dbb518d6a954845059b4a8e98e422109cc3437e705eb54538361967e00016001480b036d07462465cfc592c5cb896d226fdb01fe10000000005f5e1000001fda7146000520200000001b34e4345b6a07226f1aa91f2515096574fd6099eef1cd9885c8d069e5198cf760000000000000000000100c2eb0b00000000160014c1e616cb35cdb08332d9608f3d9d2dbf4ec34be80000000000000000ffffffff006b000000160014384e043abf63c513347c9e6b9aeb2f8f7ffd5da2000000000000000500000064000000c8", | |||
Member
There was a problem hiding this comment.
Could you take this opportunity to rename testInputs to inputs if that is not controversial?
Member
There was a problem hiding this comment.
Also nit, but IIUC, the structure of contract info will be:
outcome: String
localPayout: u64
So it might be better to rename things in the test input so that outcome is the same value that should go in the contractInfo struct (what is currently preImage), and rename what is currently called outcome to hashedOutcome or something like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were still using hashes before this PR instead of
bigsizeprefixed UTF-8 encoded strings with NFC normalization.I had to regenerate
dlc_message_test.jsonfrom scratch because I didn't have access to the pre-images of the hashes there.Note for the future:
dlc_message_test.jsonwas really valuable to me in finding what the diff was between the old test vectors and the new ones on bitcoin-s :)