Specify not to round above total collateral#207
Open
Tibo-lg wants to merge 1 commit intodiscreetlogcontracts:masterfrom
Open
Specify not to round above total collateral#207Tibo-lg wants to merge 1 commit intodiscreetlogcontracts:masterfrom
Tibo-lg wants to merge 1 commit intodiscreetlogcontracts:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@luckysori found an issue in rust dlc where the payout was being rounded above the total collateral of the contract. This PR updates the spec to specify that one should make sure to always round below the total collateral. I don't know if bitcoin-s has this issue or not.