Description to ECDSA adaptor signature and DLEQ proof types#215
Open
raulcano wants to merge 10 commits intodiscreetlogcontracts:masterfrom
Open
Description to ECDSA adaptor signature and DLEQ proof types#215raulcano wants to merge 10 commits intodiscreetlogcontracts:masterfrom
raulcano wants to merge 10 commits intodiscreetlogcontracts:masterfrom
Conversation
…or sigs and DLEQ proof types
…ent purpose in a very close section)
Author
|
Just a kind reminder to review this update. I believe it's important to have the types One caveat though, the description I have added to the Messaging.md follows the original spec of "65 bytes for an adaptor sig" and "97 bytes for a dleq proof". I would propose to slightly modify that bit to something like: Note that the new return value has:
Probably we should work out a formulation to ensure consistency but given this discussion I'm not sure if we would open a can of worms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion I initiated here #214
I believe it will be positive to add a detailed description to what exactly are the types
ecdsa_adaptor_signatureanddleq_proof. For this, I also add a new convenience typescalar.