minor correction to u64 (from BigSize) of types in the polynomial curve#216
Conversation
|
FWIW, bitcoin-s follows the spec as written: https://github.com/bitcoin-s/bitcoin-s/blob/80be2f59892b2049d66a506b1e8ae49e30c5ebe8/core/src/main/scala/org/bitcoins/core/protocol/tlv/TLV.scala#L1096 It appears that the implementation you are citing doesn't. Links would be helpful rather than just raw line numbers as it is unclear to me what files those are referring to |
|
Ok, fair enough, sorry about that. I thought the actual changed file in the commit tab was enough , but it's true it's very unconvenient to have to go and check. In any case, the inconsistency persists. I have no strong opinion on what type to keep, but either it's BigSize or it's u16. For clarity, what I was citing is not another implementation but this very specification, in the file PayoutCurve.md Lines 72 to 74 in 9cd9148 Lines 164-166: Lines 164 to 166 in 9cd9148 Line 173: Line 173 in 9cd9148 |
The text said each point has “two bigsize integers,” but the serialization (lines 164–166) and the general payout curve endpoints (lines 72–74) both use u64 for the two numeric fields. So the prose was wrong: it should say u64, not bigsize.