Signatures in oracle messages updated to Schnorr type (ECDSA signatures specified currently)#218
Open
raulcano wants to merge 1 commit intodiscreetlogcontracts:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signatures included in
oracle_announcementandoracle_attestationshould be specified as Schnorr. However, the way it is described now, it uses the field typesignature, which is defined as an ECDSA signature.This PR creates a new convenience type
schnorr_signatureand uses it in the descriptions of theoracle_announcementandoracle_attestation.Current definition of the
signatureconvenience type:dlcspecs/Messaging.md
Line 126 in 9cd9148
According to the current spec, the signature within the announcement is a Schnorr signature, but the ECDSA
signaturefield is used. See here an explicit contradition:dlcspecs/Messaging.md
Lines 418 to 427 in 9cd9148
The oracle attestation also needs of Schnorr signatures, but is pointing to the
signaturetype.dlcspecs/Messaging.md
Lines 436 to 452 in 9cd9148
For reference, this implementation of the oracle announcement and attestation uses Schnorr signatures:
https://docs.rs/dlc-messages/latest/dlc_messages/oracle_msgs/struct.OracleAnnouncement.html
https://docs.rs/dlc-messages/latest/dlc_messages/oracle_msgs/struct.OracleAttestation.html