Draft
Conversation
…nt storage approaches.
…ies of the target class.
…ght be storing base (pure virtual) classes.
Member
Author
|
@rprospero As mentioned earlier some quite significant evolution has happened here. There's a lot going on, but the summary is captured below. Thoughts, comments, and ideas for alternative approaches very welcome.
|
rprospero
reviewed
Jul 24, 2024
Contributor
rprospero
left a comment
There was a problem hiding this comment.
Overall, I like this setup and it feels clean. I've made some comments about some places where I might have handled the types differently, but there may be corner cases that I haven't considered.
Co-authored-by: Adam Washington <adam.washington@stfc.ac.uk>
Co-authored-by: Adam Washington <adam.washington@stfc.ac.uk>
…returning a pair..
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a standard interface between
QAbstractTableModeland any of our custom classes requiring such a display in the UI.TODO
insertRows()removeRows()ExpressionVariableVectorKeywordneeds to update related nodes when a parameter is removed. or added, or renamed.FilteringStandard Qt proxy model when requiredConversions
Tables with Filter Proxies
AtomTypeModelBraggReflectionModelSitesModelSpeciesSiteModelTables
DataManagerSimulationModelMasterTermModel(inherited)ModuleModelRangeVectorModelSpeciesAtomModelSpeciesBondModelSpeciesAngleModelSpeciesTorsionModelSpeciesImproperModelWeightedModuleModelXMLBondModelXMLAngleModelXMLTorsionModelXMLImproperModelQAbstractListModelsConfigurationModelEnumOptionsModelExternalPotentialModelSpeciesModelCloses #1902.