fix: correct factory test fault_none sticky, adc_sane, and heap floor checks#70
Merged
Conversation
… checks Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fault_nonewas not sticky after aFAULT_EVENTline — a subsequentfault=NONEsample reset it toTrue. Addedfault_event_seenflag that latches on firstFAULT_EVENTand gates all futurefault_noneupdates.adc_sanewas never setFalseafter an out-of-range ADC reading — a subsequent in-range reading would restore it. Addedadc_out_of_range_seenflag to make the failure sticky.heap_above_floorwas evaluated against the most recentheap_minvalue rather than the running minimum across the test window. Now tracksmin_heap_seencorrectly and recomputes the check on every RUNTIME_HEALTH line.Test plan
python tools/factory_test/run_factory_test.py --helpexits 0🤖 Generated with Claude Code