feat!: a place carries a name and a full name, on a site and on a part - #24
Merged
Merged
Conversation
§6.9 is one Location object referenced by a trip part and a dive site alike, so `sites[].location` is that object where it was a free-text string, and the object's second text member is `full_name` rather than `display_name`. The UDDF reader fills a site's locality with its name alone — `<geography>`'s coordinates are the site's own pin (§6.10) — and the writer reports the locality's `full_name`, `position` and `bbox` dropped at the locality's own path, where a note at the site's path would read as a claim about the coordinates it just wrote. The beyond-schema `south ≤ north` check reaches both hosts. `SPEC_REF` names the specification branch this vendors from; the ancestor check is red until that branch merges. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The location change is on the specification's `main`, so `SPEC_REF` names that commit rather than the branch head it was written from and the vendored trees are re-copied from it. `schema/` and `fixtures/` are unchanged; `docs/ssrf-mapping.md` rewraps one paragraph. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
§6.9 becomes one Location object that a trip part and a dive site both reference, so
sites[].locationis that object where it was a free-text string, and the object's second text member isfull_namerather thandisplay_name. The UDDF reader fills a site's locality with its name alone —<geography>'s coordinates are the site's own pin and not the locality's centre (§6.10) — and the writer reports the locality'sfull_name,positionandbboxdropped at the locality's own path, where a note at the site's path would read as a claim about the coordinates the same element just carried. A trip part goes on spending that element on itsfull_name, its own<name>already holding the name. The beyond-schemasouth ≤ northcheck reaches a site's box as well as a trip part's, reporting atsites/<i>/location/bbox.SPEC_REFnames the commit that carries this change on the specification'smain, andschema/,fixtures/anddocs/are re-vendored from it byte for byte.Verified with
pytest(1053 passing) anddivejson conform fixtures --strict(69 cases, including the new site-hosted bounding-box fixture); thespecificationjob's byte-equality, moved-past-pin and ancestor checks all pass against that commit.🤖 Generated with Claude Code