feat!: a diver's date of birth, phone, emergency contacts and insurances, read from and written to UDDF - #26
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ces, read from and written to UDDF Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
§6.1 gains a diver's
born_on,phone,emergency_contactsandinsurances, and bounds the Diver'sname,usernameandemail;SPEC_REFmoves to divejson/divejson#26's squash commit on the specification'smainandschema,fixturesanddocsare re-vendored from it. The UDDF reader fills the three members UDDF has elements for —<birthdate>, the first<phone>or else<mobilephone>, and each<insurance>— reads an owner recording any of them as a diver even without a name, and keeps its output inside the new bounds: a phone or email past its bound is dropped rather than cut, an insurer's name is capped at 255, and an insurance with an empty<name>is dropped, each reported. The writer emits the same three into<owner>in the XSD's order with dates widened to midnight, and reportsemergency_contactsand an insurance'snumber, which UDDF has no element for.Verified with
pytest,divejson conform fixtures --strict, and.github/scripts/spec_pin.pyagainst a spec checkout.🤖 Generated with Claude Code